This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add filters to search. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| args.extend(room_ids) | ||
| # Make sure we don't explode because the person is in too many rooms. | ||
| if len(room_ids) > 500: |
There was a problem hiding this comment.
Does this mean the clauses are added if the user is in more than 500 rooms?
There was a problem hiding this comment.
If the clauses are omitted do we have a way to ensure that the user only sees the events for the rooms they are in?
|
LGTM |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.