This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use stream rather depth ordering for push actions #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies things as it is, but will also allow us to change the way we traverse topologically without having to update the way push actions work.
richvdh
reviewed
May 11, 2018
| @@ -407,7 +407,6 @@ def insert_linearized_receipt_txn(self, txn, room_id, receipt_type, | |||
| txn, | |||
| room_id=room_id, | |||
| user_id=user_id, | |||
| topological_ordering=topological_ordering, | |||
There was a problem hiding this comment.
wonder if we ought to make the comparison at line 375 ignore topo ordering. Might fix the fact I currently have 1110 unread messages in #matrix-dev too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies things as it is, but will also allow us to change the
way we traverse topologically without having to update the way push
actions work.