Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Only update remote profile cache on master #2989

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Only update remote profile cache on master #2989

merged 1 commit into from
Mar 14, 2018

Conversation

erikjohnston
Copy link
Member

The updates get persisted and fetched from the DB, so this can and should only be run on master.

richvdh
richvdh approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels like we ought to do this by not instantiating a Handler which does the update on the workers, but I guess this is ok

@richvdh richvdh assigned erikjohnston and unassigned richvdh Mar 13, 2018
@erikjohnston
Copy link
Member Author

it feels like we ought to do this by not instantiating a Handler which does the update on the workers, but I guess this is ok

Agreed, I think we should at some point look at splitting the handlers into master/worker pairs like the stores.

@erikjohnston erikjohnston merged commit 3e839e0 into develop Mar 14, 2018
@erikjohnston erikjohnston deleted the erikj/profile_cache_master branch March 22, 2018 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh