This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Factor out _remote_reject_invite in RoomMember #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/factor_remote_leave
branch
from
eff3c64 to
0f942f6
Compare
richvdh
reviewed
Mar 13, 2018
| @@ -154,6 +154,30 @@ def remote_join(self, remote_room_hosts, room_id, user, content): | |||
| ) | |||
| yield user_joined_room(self.distributor, user, room_id) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def _remote_reject_invite(self, remote_room_hosts, room_id, target): | |||
There was a problem hiding this comment.
please could you add a docstring documenting the params and return value? I don't want to have to go spelunking to figure it out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.