Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable responding with canonical JSON for federation. #2951

Open
jevolk opened this issue Mar 6, 2018 · 1 comment
Open

Enable responding with canonical JSON for federation. #2951

jevolk opened this issue Mar 6, 2018 · 1 comment
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@jevolk
Copy link

jevolk commented Mar 6, 2018

Due to the conclusions of matrix-doc matrix-org/matrix-spec#255 the server should only transmit the exact string of bytes that it signed (canonical JSON). This probably reverts matrix-org/matrix-spec-proposals#878.

Please consider this high priority. The change is trivial and can be shipped immediately.

@reivilibre
Copy link
Contributor

This one is quite an old issue, but my reading of it is that sending out canonical JSON over the wire allows the receiving homeserver to be able to optimistically support checking the signature of the event, without need to first reserialise the event as Canonical JSON (except there would be a few catches due to some fields needing to be skipped).

There have also been suggestions about just using CBOR or friends to reduce the faff, but I suppose none of that materialised since 2018 :-).

@reivilibre reivilibre added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants