This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve caching for read_marker API #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed Sytest is failing on |
|
The other sytest failed because perl failed to install |
richvdh
reviewed
Mar 1, 2018
synapse/storage/account_data.py
Outdated
| @@ -156,6 +157,38 @@ def get_account_data_for_room_txn(txn): | |||
| "get_account_data_for_room", get_account_data_for_room_txn | |||
| ) | |||
|
|
|||
| @cached(num_args=3, max_entries=5000) | |||
| def get_account_data_for_room_and_type(self, user_id, room_id, account_data_type): | |||
| """Get all the client account_data for a user for a room. | |||
synapse/storage/account_data.py
Outdated
| room_id(str): The room to get the account_data for. | ||
| account_data_type (str): The account data type to get. | ||
| Returns: | ||
| A deferred dict of the room account_data for that type, or None if |
| @@ -2033,7 +2033,7 @@ def is_event_after(self, event_id1, event_id2): | |||
| to_2, so_2 = yield self._get_event_ordering(event_id2) | |||
| defer.returnValue((to_1, so_1) > (to_2, so_2)) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| @cachedInlineCallbacks(max_entries=5000) | |||
There was a problem hiding this comment.
I'd really prefer it if we used
@cached()
@defer.inlineCallbacks
but I'm not going to argue too much about it
There was a problem hiding this comment.
Me too, but I think this is something to be investigated outside this PR.
We add a new storage function to get a paritcular type of room account data. This allows us to prefill the cache when updating that acount data.
erikjohnston
force-pushed
the
erikj/read_marker_caches
branch
from
5d72c68 to
4b44f05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I've also added some sytests matrix-org/sytest#433)