This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make repl send_event idempotent and retry on timeouts #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we treated timeouts as failures on the worker we would attempt to clean up e.g. push actions while the master might still process the event.
richvdh
approved these changes
Mar 1, 2018
|
|
||
| def on_PUT(self, request, event_id): | ||
| result = self.response_cache.get(event_id) | ||
| if not result: |
There was a problem hiding this comment.
I'd suggest adding a line of logging for the case where there is an entry in the cache already.
| except CodeMessageException as e: | ||
| if e.code != 504: | ||
| raise | ||
|
|
richvdh
reviewed
Mar 1, 2018
| if not result: | ||
| result = self.response_cache.set( | ||
| event_id, | ||
| preserve_fn(self._handle_request)(request) |
There was a problem hiding this comment.
can you preserve_fn this once rather than on every request?
richvdh
reviewed
Mar 1, 2018
| break | ||
| except CodeMessageException as e: | ||
| if e.code != 504: | ||
| logger.warn("send_event request timed out") |
richvdh
reviewed
Mar 1, 2018
| def on_PUT(self, request, event_id): | ||
| result = self.response_cache.get(event_id) | ||
| if not result: | ||
| logger.warn("Returning cached response") |
richvdh
reviewed
Mar 1, 2018
| self._handle_request(request) | ||
| ) | ||
| else: | ||
| logger.warn("Returning cached response") |
There was a problem hiding this comment.
I wouldn't mind if you logged the state of result.called (ie whether we're returning a completed response or are still waiting for the request to complete), but this is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we treated timeouts as failures on the worker we would attempt to
clean up e.g. push actions while the master might still process the
event.