This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Split out get_events and co into a worker store #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
erikjohnston
force-pushed
the
erikj/split_events_store
branch
from
a38c009 to
27b094f
Compare
richvdh
approved these changes
Feb 22, 2018
synapse/storage/events.py
Outdated
| EVENT_ORIGIN_SERVER_TS_NAME = "event_origin_server_ts" | ||
| EVENT_FIELDS_SENDER_URL_UPDATE_NAME = "event_fields_sender_url" | ||
|
|
||
| class EventsWorkerStore(SQLBaseStore): |
There was a problem hiding this comment.
shouldn't _event_persist_queue be in the EventsStore?
synapse/storage/events.py
Outdated
|
|
||
| def __init__(self, db_conn, hs): | ||
| super(EventsStore, self).__init__(db_conn, hs) | ||
| self._clock = hs.get_clock() |
There was a problem hiding this comment.
this appears to be redundant, fwiw.
|
oh, I wonder if it would be worth putting EventsWorkerStore in a separate python file. events.py is pretty huge. |
|
I've split out the events into two files, do you want to take a quick look before I merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff for
synapse.storage.eventsis a bit silly, all I've done is move the functions up the file.