This repository was archived by the owner on Apr 26, 2024. It is now read-only.
When updating a stored event from outlier to non-outlier, remember to update the extremeties #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update the extremeties
| @@ -303,6 +303,9 @@ def _handle_mult_prev_events(self, txn, events): | |||
| ], | |||
| ) | |||
|
|
|||
| self._update_extremeties(txn, events) | |||
|
|
|||
| def _update_extremeties(self, txn, events): | |||
| events_by_room = {} | |||
There was a problem hiding this comment.
Can we have a some documentation for what this method does?
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Sep 15, 2015
When updating a stored event from outlier to non-outlier, remember to update the extremeties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: https://matrix.org/jira/browse/SYN-392
Summary: Three users A¹, A² and B¹ are on servers A and B. If A¹ and B¹ are in a room and B¹ invites A², then A² is unable to join.