This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix 500 when joining matrix-dev #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
suggested changes
Nov 28, 2017
synapse/events/__init__.py
Outdated
| @@ -72,6 +72,10 @@ def __init__(self, event_dict, signatures={}, unsigned={}, | |||
|
|
|||
| self._event_dict = event_dict | |||
|
|
|||
| # some malformed events have no hashes. Avoid throwing exceptions | |||
| # later. | |||
| event_dict.setdefault("hashes", {}) | |||
There was a problem hiding this comment.
We really don't want to be editing the dict here, as it will invalidate any signatures
There was a problem hiding this comment.
oh yes. Poop.
any better suggestions? I'm kinda keen to avoid having to do a getattr every time we touch the hashes.
Possibly a _event_dict_property_with_default which builds a property which has a default?
erikjohnston
approved these changes
Nov 29, 2017
matrix-dev has an event (`$/6ANj/9QWQyd71N6DpRQPf+SDUu11+HVMeKSpMzBCwM:zemos.net`) which has no `hashes` member. Check for missing `hashes` element in events.
richvdh
force-pushed
the
rav/handle_missing_hashes
branch
from
3f5ff9f to
7303ed6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-dev has an event (
$/6ANj/9QWQyd71N6DpRQPf+SDUu11+HVMeKSpMzBCwM:zemos.net)which has no
hashesmember.Set a default on event.hashes so that we don't fall over later.