This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve documentation of workers #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Nov 21, 2017
docs/workers.rst
Outdated
|
|
||
| ``synapse.app.federation_reader`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| handles receiving federation traffic (including public_rooms API). In |
turt2live
reviewed
Nov 21, 2017
| The above endpoints should all be routed to the synchrotron worker by the | ||
| reverse-proxy configuration. | ||
|
|
||
| It is possible to run multiple instances of the synchrotron to scale |
There was a problem hiding this comment.
for clarity, the other workers should indicate that they cannot be load balanced. Probably just a paragraph above the workers saying "All workers cannot be load balanced unless otherwise stated".
There was a problem hiding this comment.
I don't actually think that's true: I think that most of them can be load-balanced, though the greatest gains are to be found via the synchrotrons. I've identified the ones that definitely can't be load-balanced in 879adee.
turt2live
reviewed
Nov 21, 2017
docs/workers.rst
Outdated
| the ``worker_main_http_uri`` setting in the frontend_proxy worker configuration | ||
| file. For example:: | ||
|
|
||
| worker_main_http_uri: http://127.0.0.1:8080 |
There was a problem hiding this comment.
ours is on :8080. but fair enough, I guess :8008 is more common.
|
I'll merge this in a bit if nobody spots any more problems |
richvdh
force-pushed
the
rav/worker_docs
branch
from
879adee to
a0c6688
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2554