This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Avoid locking account_data tables for upserts #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| txn.call_after( | ||
| self.get_global_account_data_by_type_for_user.invalidate, | ||
| self.get_account_data_for_user.invalidate((user_id,)) | ||
| self.get_global_account_data_by_type_for_user.invalidate( | ||
| (account_data_type, user_id,) | ||
| ) |
There was a problem hiding this comment.
I think we might need to think if its fine that the invalidation happens after another yield or not, I'm suspecting not.
There was a problem hiding this comment.
I wondered that. But given there was no guarantee how quickly after the db update the invalidation was happening before, I couldn't see how it could make any difference. The extra yield is equivalent a sleep() in the db update thread before the call_after code returns.
Unless, of course, there's a race already, in which case yes this will make it worse...
erikjohnston
approved these changes
Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.