This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Device deletion: check UI auth matches access token #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(otherwise there's no point in the UI auth)
erikjohnston
approved these changes
Oct 27, 2017
| # check that the UI auth matched the access token | ||
| user_id = result[constants.LoginType.PASSWORD] | ||
| if user_id != requester.user.to_string(): | ||
| raise errors.AuthError(403, "Invalid auth") |
There was a problem hiding this comment.
I... am slightly surprised that check_auth doesn't either return or accept a user_id. OTOH, seems to be what everywhere else does so lets not try and fix it in this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(otherwise there's no point in the UI auth)