This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix port script #2577
Merged
Fix port script #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed _simple_update_one_txn to use _simple_update_txn but didn't yank it out in the port script. Fixes #2565
richvdh
approved these changes
Oct 26, 2017
| @@ -112,6 +112,7 @@ class Store(object): | |||
|
|
|||
| _simple_update_one = SQLBaseStore.__dict__["_simple_update_one"] | |||
| @@ -112,6 +112,7 @@ class Store(object): | |||
|
|
|||
| _simple_update_one = SQLBaseStore.__dict__["_simple_update_one"] | |||
| _simple_update_one_txn = SQLBaseStore.__dict__["_simple_update_one_txn"] | |||
There was a problem hiding this comment.
It gets used as well in the script?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed _simple_update_one_txn to use _simple_update_txn but didn't
yank it out in the port script.
Fixes #2565