This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add config option to specify where generated files should be dumped #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,6 +145,12 @@ def load_config(cls, description, argv, generate_section=None): | |||
| help="Generate any missing key files then exit" | |||
| ) | |||
| config_parser.add_argument( | |||
| "--generated-directory", | |||
There was a problem hiding this comment.
I wonder if "generated-keys-directory" or something would be a better name.
There was a problem hiding this comment.
Suggestions welcome?
| "--generated-directory", | ||
| metavar="DIRECTORY", | ||
| help="Used with 'generate-*' options to specify where generated" | ||
| " files (such as certs and signing keys) should be stored." |
There was a problem hiding this comment.
It might be worth saying that if the location of a key file is explicitly given in the config then that location will be used.
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Aug 25, 2015
Add config option to specify where generated files should be dumped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.