This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow spam checker to reject invites too #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
reviewed
Oct 3, 2017
synapse/handlers/room_member.py
Outdated
| block_invite = True | ||
|
|
||
| if not self.spam_checker.user_may_invite(requester.user): | ||
| block_invite = True |
There was a problem hiding this comment.
Do we want this to apply to server admins?
erikjohnston
reviewed
Oct 3, 2017
synapse/events/spamcheck.py
Outdated
| @@ -45,3 +45,19 @@ def check_event_for_spam(self, event): | |||
| return False | |||
|
|
|||
| return self.spam_checker.check_event_for_spam(event) | |||
|
|
|||
| def user_may_invite(self, userid): | |||
There was a problem hiding this comment.
I wonder if we also want to include the room_id here, so that you can fonx all invites for known bad rooms (or whitelist known good rooms)
erikjohnston
reviewed
Oct 3, 2017
synapse/events/spamcheck.py
Outdated
| @@ -45,3 +45,19 @@ def check_event_for_spam(self, event): | |||
| return False | |||
|
|
|||
| return self.spam_checker.check_event_for_spam(event) | |||
|
|
|||
| def user_may_invite(self, userid, roomid): | |||
There was a problem hiding this comment.
Normally we call it room_id
erikjohnston
approved these changes
Oct 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.