This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add support for event_id_only push format #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Param in the data dict of a pusher that tells an HTTP pusher to send just the event_id of the event it's notifying about and the notification counts. For clients that want to go & fetch the body of the event themselves anyway.
synapse/push/httppusher.py
Outdated
| @@ -244,6 +244,25 @@ def _process_one(self, push_action): | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def _build_notification_dict(self, event, tweaks, badge): | |||
| if 'format' in self.data and self.data['format'] == 'event_id_only': | |||
There was a problem hiding this comment.
I'd tend to just do if self.data.get("format") == "event_id_only":
erikjohnston
approved these changes
Sep 18, 2017
erikjohnston
suggested changes
Sep 18, 2017
as really it's part of the event ID
erikjohnston
approved these changes
Sep 18, 2017
|
What does this pr do? (Can you explain for a non programmer please?) |
This was referenced Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Param in the data dict of a pusher that tells an HTTP pusher to
send just the event_id of the event it's notifying about and the
notification counts. For clients that want to go & fetch the body
of the event themselves anyway.