-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable compression for federation by default in config #2434
Comments
Since most of the c2s and s2s communication is text, it would greatly benefit in performance from the common gzip compression. I might even go as far as suggesting that there would be even more benefit in adding brotli compression which is supported by most browsers these days and certainly by Chrome/Electron which Riot is based upon. It might be possible to add compression when |
Compression is already implemented but not enabled by default -> nginx/proxy is not strictly necessary |
is there any reason not to enable this? |
http://breachattack.com/ possibly, but I don't think it applies here |
BREACH and CRIME seem like suitable enough reasons not to use compression; after all, we are combining compressible data from different users together in the same compressed stream and the length of the compressed payload is therefore a possibly exploitable side channel. |
I think compression should be enabled by default for both, client and federation, because it reduces traffic. My own server does not seem to have higher cpu loads than normal and because it is enabled for clients by default i can't think of any reason not to enable it for federation.
The text was updated successfully, but these errors were encountered: