This repository was archived by the owner on Apr 26, 2024. It is now read-only.
python_dependencies: Use bcrypt module instead of py-bcrypt #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py-bcrypt has been unmaintained for a long while, while bcrypt is actively maintained. And since ff8b871 we're compatible with the bcrypt anyway. Signed-off-by: Johannes Löthberg <[email protected]>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
oy-oy? |
|
@erikjohnston this looks like the right solution? |
|
Probably? |
|
this should avoid things like #2345 in future. |
|
(Thanks @kyrias) |
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Aug 23, 2017
to stop breakage occuring with modern python bcrypt. (We now use bcrypt 3 in synapse, as of matrix-org/synapse#2288)
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Aug 23, 2017
to stop breakage occuring with modern python bcrypt. (We now use bcrypt 3 in synapse, as of matrix-org/synapse#2288)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py-bcrypt has been unmaintained for a long while, while bcrypt is
actively maintained. And since ff8b871
we're compatible with the bcrypt anyway.
This allows distro maintainer to drop the unmaintained module which also
happens to conflict with the bcrypt module.