This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make calculating push actions faster #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/faster_push_rules
branch
from
fc7b03b to
295276c
Compare
erikjohnston
added
maintenance
A-Performance
erikjohnston
force-pushed
the
erikj/faster_push_rules
branch
6 times, most recently
from
be0ce1f to
e887489
Compare
erikjohnston
force-pushed
the
erikj/faster_push_rules
branch
2 times, most recently
from
7472680 to
a4f1ce8
Compare
We add a push rule specific cache that ensures that we can reuse calculated push rules appropriately when a user join/leaves.
erikjohnston
force-pushed
the
erikj/faster_push_rules
branch
from
f0cbb14 to
66d8ffa
Compare
| Returns: | ||
| RulesForRoom | ||
| """ | ||
| return RulesForRoom(self.hs, room_id, self._get_rules_for_room.cache) |
There was a problem hiding this comment.
I think it's important that the RulesForRoom object is added to the self._get_rules_for_room.cache before any lookup methods are called on it, otherwise there would be a race in RulesForFroom.invalidate_all between adding the object to the cache and fetching it from the cache to invalidate it.
Might be worth chucking a comment in to that effect.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.