This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement no op for room stream in sync #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synapse/handlers/sync.py
Outdated
| @@ -818,6 +831,38 @@ def handle_room_entries(room_entry): | |||
| defer.returnValue((newly_joined_rooms, newly_joined_users)) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def _have_rooms_changed(self, sync_result_builder): | |||
| """Returns whether any rooms have changed since the sync. Must be an | |||
| incremental sync | |||
There was a problem hiding this comment.
Would the doctring be clearer if it was written something like this?
"""Returns true if there are any new events in the rooms the user is in since the last sync
or if the user has changed membership in any room since the last sync.
This only makes sense when calculating an incremental sync."""| @@ -274,24 +274,25 @@ def _get_members_rows_txn(self, txn, room_id, membership=None, user_id=None): | |||
|
|
|||
| return rows | |||
|
|
|||
| @cached(max_entries=500000, iterable=True) | |||
| @cachedInlineCallbacks(max_entries=500000, iterable=True) | |||
| def get_rooms_for_user(self, user_id): | |||
There was a problem hiding this comment.
Would it make sense to have some docstring along the lines of:
"""Returns an immutable set of room_id strings for the rooms the user is joined to."""| @@ -765,6 +764,21 @@ def _generate_sync_entry_for_rooms(self, sync_result_builder, account_data_by_ro | |||
| ) | |||
| sync_result_builder.now_token = now_token | |||
|
|
|||
| # We check up front if anything has changed, if it hasn't then there is | |||
| # no point in going futher. | |||
There was a problem hiding this comment.
Maybe comment on what expensive operations this avoids?
There was a problem hiding this comment.
It feels like that sort of comment would get out of date quickly, and wouldn't necessarily help that much.
|
Looks good codewise. I think the comments could be improved slightly but overall it looks pretty good. |
|
Updated comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.