Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement /keys/changes #1869

Merged
merged 3 commits into from
Feb 1, 2017
Merged

Implement /keys/changes #1869

merged 3 commits into from
Feb 1, 2017

Conversation

erikjohnston
Copy link
Member

No description provided.

@@ -149,6 +151,52 @@ def on_POST(self, request):
defer.returnValue((200, result))


class KeyChangesServlet(RestServlet):
"""Returns the list of changes of keys between two stream tokens (may return
spurious results).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe explain why the results might be spurious and the nature of their spuriosity?

Copy link
Contributor

@NegativeMjark NegativeMjark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikjohnston erikjohnston merged commit bd84387 into develop Feb 1, 2017
@erikjohnston erikjohnston deleted the erikj/device_list_stream branch March 29, 2017 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants