This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Speed up deleting device messages #16643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/faster_device_message_deletion
branch
from
67db2de to
df6ab79
Compare
erikjohnston
force-pushed
the
erikj/faster_device_message_deletion
branch
from
df6ab79 to
1293012
Compare
reivilibre
approved these changes
Nov 16, 2023
Co-authored-by: reivilibre <[email protected]>
clokep
reviewed
Nov 16, 2023
clokep
reviewed
Nov 16, 2023
clokep
reviewed
Nov 16, 2023
clokep
reviewed
Nov 16, 2023
Co-authored-by: Patrick Cloke <[email protected]>
clokep
reviewed
Nov 16, 2023
clokep
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping track of a lower bound of stream ID where we've deleted everything below makes the queries much faster. Otherwise, every time we scan for rows to delete we'd re-scan across all the rows that have previously deleted (until the next table VACUUM).