This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Stop generating refresh_tokens #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/no_more_refresh_tokens
branch
3 times, most recently
from
ce8d0d7 to
e7593c9
Compare
Since we're not doing refresh tokens any more, we should start killing off the dead code paths. /tokenrefresh itself is a bit of a thornier subject, since there might be apps out there using it, but we can at least not generate refresh tokens on new logins.
richvdh
force-pushed
the
rav/no_more_refresh_tokens
branch
from
e7593c9 to
5c4edc8
Compare
We might as well treat all refresh_tokens as invalid. Just return a 403 from /tokenrefresh, so that we don't have a load of dead, untestable code hanging around. Still TODO: removing the table from the schema.
| @@ -386,8 +386,8 @@ def _create_registration_details(self, user_id, params): | |||
| """ | |||
There was a problem hiding this comment.
The doc-string still refers to refresh_tokens
|
We might want to remove the refresh_tokens database table at somepoint, but fitting that into the schema upgrade process might be subtle given that there are background updates run against that table. So lets leave that for another PR so that it can be reviewed properly. |
|
Other than the stale docstring LGTM. |
yeah, I came to exactly the same conclusion. |
Remove refresh_token reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh tokens are dead, so let's stop trying to generate new ones.