This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Mark sync as limited if there is a gap in the timeline #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits thinsg into two queries, but most of the time we won't have new event backwards extremities so this shouldn't actually add an extra RTT for the majority of cases. Note this removes the check for events with no prev events, but that was part of MSC2716 work that has since been removed.
clokep
reviewed
Oct 16, 2023
Comment on lines
+614
to
+615
| # If there is a gap then we need to only include events after | ||
| # it. |
There was a problem hiding this comment.
Suggested change
| # If there is a gap then we need to only include events after | |
| # it. | |
| # If there is a gap then we need to include only events after | |
| # it. |
Maybe? I'm not sure why we would do this though?
There was a problem hiding this comment.
If we have a section of the timeline with events A, B, <gap>, X, Y, Z we need to make sure we only send down X, Y, Z and not A and B (which we currently do. If we did, then the client wouldn't try and paginate to fill in the gap.
clokep
approved these changes
Oct 17, 2023
Can someone write a bot to remind me about tests being a thing?? |
|
@clokep I wrote a test and it found an edge case! I've hopefully fixed it.... |
clokep
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16463