This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support releasing on macOS. #16266
Merged
Support releasing on macOS. #16266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
Sep 6, 2023
Comment on lines
577
to
578
| # Try and run notify-send, but don't raise an Exception if this fails | ||
| # (This is best-effort) |
There was a problem hiding this comment.
This is a lie -- I got an exception that the binary couldn't be found.
erikjohnston
approved these changes
Sep 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were changes I had to make to the release script in order to get 1.91.2 out the door.