This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Unconfigurable harsh ratelimiting for leaving rooms #16006
Labels
A-Config
Configuration, or the documentation thereof
A-Leave
Leaving a room
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
Comments
MatMaul
added
A-Config
Configuration, or the documentation thereof
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
O-Occasional
Affects or can be seen by some users regularly or most users rarely
A-Leave
Leaving a room
labels
Jul 27, 2023
Initial reactions:
|
Here are some logs
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Yes, it's not a public homeserver. Do you need it to debug? |
(Note that seychelles111 is not a member of the Synapse core team). |
This comment was marked as off-topic.
This comment was marked as off-topic.
#16135 should help with this. |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Config
Configuration, or the documentation thereof
A-Leave
Leaving a room
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
Description
Clients (at least Element) have an option to leave a space and leave all rooms in it.
If you choose to leave all rooms, the client will make leave requests for every room you are on.
If you are on many rooms, this will take a long time, to the point it seems like it hangs. Looking at the network tab in the developer tools shows a lot of 429 Too Many Requests responses.
In conclusion, the defualt ratelimiting for leaving rooms is too harsh. It doesn't seem like it can be overriden either:
https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html has mention of
rc_joins
but there is norc_leaves
Steps to reproduce
Homeserver
matrix.mit.edu
Synapse Version
{"server_version":"1.88.0","python_version":"3.10.6"}
Installation Method
Debian packages from packages.matrix.org
Database
PostgreSQL
Workers
Single process
Platform
Ubuntu 22.04.2, PowerEdge R710
Configuration
No response
Relevant log output
Anything else that would be useful to know?
No response
The text was updated successfully, but these errors were encountered: