Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

sending typing notice event doesn't update m.presence (SYN-541) #1439

Closed
matrixbot opened this issue Dec 8, 2015 · 2 comments
Closed

sending typing notice event doesn't update m.presence (SYN-541) #1439

matrixbot opened this issue Dec 8, 2015 · 2 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@matrixbot
Copy link
Member

Submitted by @​richvdh:matrix.org

(Imported from https://matrix.org/jira/browse/SYN-541)
@matrixbot matrixbot changed the title sending typing notice event doesn't update m.presence (SYN-541) sending typing notice event doesn't update m.presence (https://github.com/matrix-org/synapse/issues/1439) Nov 7, 2016
@matrixbot matrixbot changed the title sending typing notice event doesn't update m.presence (https://github.com/matrix-org/synapse/issues/1439) sending typing notice event doesn't update m.presence (SYN-541) Nov 7, 2016
@H-Shay H-Shay added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. labels Mar 22, 2023
@realtyem realtyem mentioned this issue Jul 5, 2023
Open
@realtyem
Copy link
Contributor

Looks like this has existed(in a fixed state) since at least Feb 27th, 2016 in commit e5999bf#diff-a4bb01be1e5402dc57d2a80b618edba38940a12f0972326a9d8e35f2fe89cbdfR547 where a call to bump the last active time of the PresenceState for the user effectively updates presence(unless already currently_active) which is sufficient to bring a user out of offline/unavailable.

I believe this was part of the initial rewrite of the presence system?

I think this has been completed. The question of whether time has granted us the wisdom that this is a 'Good Thing' or not is still up for debate(and would probably be the topic of another issue anyways).

@clokep
Copy link
Member

clokep commented Jul 25, 2023

Seems reasonable to close this then. 👍

@clokep clokep closed this as completed Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clokep @realtyem @matrixbot @H-Shay