Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

PUT /dehydrated_device is broken and doesn't accept valid requests #14334

Closed
t3chguy opened this issue Oct 31, 2022 · 4 comments · Fixed by #14336
Closed

PUT /dehydrated_device is broken and doesn't accept valid requests #14334

t3chguy opened this issue Oct 31, 2022 · 4 comments · Fixed by #14336
Assignees
@DMRobertson
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@t3chguy
Copy link
Member

t3chguy commented Oct 31, 2022 •
edited
Loading

Description

See matrix-org/matrix-js-sdk#2809
See https://github.com/matrix-org/synapse/pull/14054/files#r1009320711

The PUT API is demanding a device_id body param, which is not part of the MSC. https://github.com/uhoreg/matrix-doc/blob/dehydration/proposals/2697-device-dehydration.md#dehydrating-a-device

Steps to reproduce

  • Send valid PUT /dehydrated_device request
  • Receive 400 (Bad Request) M_MISSING_PARAM: MatrixError: [400] 1 validation error for PutBody device_id field required (type=value_error.missing) (/_matrix/client/unstable/org.matrix.msc2697.v2/dehydrated_device)

Homeserver

Any

Synapse Version

1.70.0

Installation Method

No response

Platform

Any

Relevant log output

M_MISSING_PARAM: MatrixError: [400] 1 validation error for PutBody device_id field required (type=value_error.missing) (/_matrix/client/unstable/org.matrix.msc2697.v2/dehydrated_device)

Anything else that would be useful to know?

Regressed by #14054
@t3chguy t3chguy mentioned this issue Oct 31, 2022
Closed
@clokep
Copy link
Member

clokep commented Oct 31, 2022

To make it explicit -- this regressed in v1.70.0rc1.

@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release X-Regression Something broke which worked on a previous release O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 31, 2022
@DMRobertson
Copy link
Contributor

@clokep Are you sure this is a regression? AFAICS from https://github.com/matrix-org/synapse/pull/14054/files?diff=split&w=0#diff-7225331690e55a76b271fbcaf20bed5aaaf69fb5a21b03a9bf297929b157ba1cL300-R333 we were always looking for device_id in the request body.

@t3chguy
Copy link
Member Author

t3chguy commented Oct 31, 2022

@DMRobertson that's POST, this issue is about PUT

@DMRobertson
Copy link
Contributor

Ahh yes, thanks.

@DMRobertson DMRobertson mentioned this issue Oct 31, 2022
Merged
@DMRobertson DMRobertson self-assigned this Oct 31, 2022
@menturion menturion mentioned this issue Mar 1, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dehydrated device REST checks matrix-org/synapse
3 participants
@clokep @t3chguy @DMRobertson