Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

filter_events_for_client is time-consuming and expensive #14108

Closed
Tracked by #14284
MadLittleMods opened this issue Oct 7, 2022 · 3 comments · Fixed by #14527
Closed
Tracked by #14284

filter_events_for_client is time-consuming and expensive #14108

MadLittleMods opened this issue Oct 7, 2022 · 3 comments · Fixed by #14527
Assignees
@MadLittleMods
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Milestone
Faster /messages

Comments

@MadLittleMods
Copy link
Contributor

filter_events_for_client is time-consuming and expensive.

From this /messages request (full trace), it takes 7.83s for 500 events and is one of the biggest time saves left after other /messages optimizations we've already made. Most of time is just spent in the database getting the state out.

/message trace in Jaeger show how slow `filter_events_for_client` is

Related to filter_events_for_server being expensive, #3526
@MadLittleMods MadLittleMods added the A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) label Oct 7, 2022
@MadLittleMods MadLittleMods mentioned this issue Oct 7, 2022
Open
@erikjohnston
Copy link
Member

Interesting. What sort of room is this? For large public rooms (and smaller rooms) it should be really quite fast

@erikjohnston erikjohnston added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. S-Minor Blocks non-critical functionality, workarounds exist. labels Oct 11, 2022
@MadLittleMods
Copy link
Contributor Author

MadLittleMods commented Oct 11, 2022 •
edited
Loading

@erikjohnston The beeg one #matrix:matrix.org (Matrix HQ) 🗿 (the 200k state events probably isn't helping)

@erikjohnston
Copy link
Member

Huh, but it should only be pulling out a couple of pieces of state (the history visibility mainly). Which should not take that long :/

@kittykat kittykat mentioned this issue Oct 24, 2022
Closed
7 tasks
@MadLittleMods MadLittleMods mentioned this issue Nov 19, 2022
Closed
4 tasks
@MadLittleMods MadLittleMods self-assigned this Nov 19, 2022
MadLittleMods added a commit that referenced this issue Nov 22, 2022
@MadLittleMods
Optimize filter_events_for_client for faster /messages
fdf1fd3 
Seems like it will make it a magnitude faster.

Fix #14108

Part of #13356 (comment)
@MadLittleMods MadLittleMods mentioned this issue Nov 22, 2022
Merged
4 tasks
erikjohnston pushed a commit that referenced this issue Nov 22, 2022
@MadLittleMods
Optimize filter_events_for_client for faster /messages - v2 (#14527)
7f78b38 
Fix #14108
H-Shay pushed a commit that referenced this issue Dec 13, 2022
@MadLittleMods @H-Shay
Optimize filter_events_for_client for faster /messages - v2 (#14527)
a7acb1f 
Fix #14108
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MadLittleMods MadLittleMods

Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
Faster /messages
2 participants
@MadLittleMods @erikjohnston