This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

The changelog entry ending in a `.` or `!` is not optional #14087

Merged

DMRobertson merged 1 commit into matrix-org:develop from klaernie:patch

Oct 6, 2022

Contributor

klaernie commented Oct 6, 2022 •

edited

Loading

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Pull request includes a sign off
Code style is correct
(run the linters)

klaernie requested a review from a team as a code owner

October 6, 2022 15:41


          The changelog entry ending in a full stop or exclamation mark is not …

3b08aa4

…optional

Signed-off-by: Andre Klaerner <[email protected]>

klaernie force-pushed the patch branch from a690759 to 3b08aa4 Compare

October 6, 2022 15:43

DMRobertson approved these changes

View reviewed changes

Contributor

DMRobertson left a comment

Very fair. Shout-out to RFC 2119!

DMRobertson enabled auto-merge (squash)

October 6, 2022 16:35

DMRobertson merged commit b753f63 into matrix-org:develop

klaernie deleted the patch branch

October 6, 2022 17:19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet