Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Prune 'left' members of rooms in CS API from initial /sync? (SYN-487) #1379

Closed
matrixbot opened this issue Sep 22, 2015 · 3 comments
Closed

Prune 'left' members of rooms in CS API from initial /sync? (SYN-487) #1379

matrixbot opened this issue Sep 22, 2015 · 3 comments
Labels
z-feature (Deprecated Label) z-p2 (Deprecated Label)

Comments

@matrixbot
Copy link
Member

Clients surely never care about users who are in state 'left' in a room. Can we not just prune them from the state that's passed to the client?

(Imported from https://matrix.org/jira/browse/SYN-487)

(Reported by @ara4n)
@matrixbot
Copy link
Member Author

Jira watchers: @ara4n

@matrixbot matrixbot added z-p2 (Deprecated Label) z-feature (Deprecated Label) labels Nov 7, 2016
@matrixbot matrixbot changed the title Prune 'left' members of rooms in CS API? (SYN-487) Prune 'left' members of rooms in CS API? (https://github.com/matrix-org/synapse/issues/1379) Nov 7, 2016
@matrixbot matrixbot changed the title Prune 'left' members of rooms in CS API? (https://github.com/matrix-org/synapse/issues/1379) Prune 'left' members of rooms in CS API? (SYN-487) Nov 7, 2016
@ara4n ara4n mentioned this issue Dec 30, 2016
Closed
@ara4n ara4n changed the title Prune 'left' members of rooms in CS API? (SYN-487) Prune 'left' members of rooms in CS API from initial /sync? (SYN-487) Dec 30, 2016
@ara4n
Copy link
Member

ara4n commented Dec 30, 2016

@erikjohnston can you remind me why we're not doing this? Is it because /messages may get confused if you try to back-paginate from an initial /sync, and members suddenly pop into life who weren't even mentioned in the initial /sync response?

This was referenced May 20, 2018
Merged
Closed
@babolivier
Copy link
Contributor

Fixed by #2970

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-feature (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @babolivier @matrixbot