Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Determine if anyone finds the Prometheus console useful enough to justify recording rules that only it uses #13758

Closed
reivilibre opened this issue Sep 8, 2022 · 2 comments · Fixed by #13876
Assignees
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@reivilibre
Copy link
Contributor

In #13756 it became apparent that we have several Prometheus recording rules whose only appearance is in the Prometheus console file here: https://github.com/matrix-org/synapse/blob/develop/contrib/prometheus/consoles/synapse.html

I have never used this and have never seen anyone use this.

@richvdh touched it most recently — do you use it?

If nobody uses it (I wonder if it was 'the answer' before Grafana), I suggest we remove it, or at least remove the recording rules that aren't used anywhere else, in order to cut down on how much useless stuff we record in Prometheus.

@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Sep 8, 2022
@reivilibre reivilibre self-assigned this Sep 8, 2022
@dklimpel
Copy link
Contributor

dklimpel commented Sep 9, 2022

I find the prometheus console / dashboard helpful. It is a way to easily and quickly get to the most important synapse metrics without reading the long and complex Grafana json or implementing a Grafana stack. IMO Grafana is more complex and difficult to get started with than prometheus.
But maybe it was just the reason that an overview of the most important metrics of Synpase is missing in the documentation.

@richvdh
Copy link
Member

richvdh commented Sep 19, 2022

I certainly don't use it. I suspect very few people do.

Perhaps a low-effort solution would just be to comment on the recording rules that they aren't needed unless using that console.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
3 participants