Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Disabling historical rooms #13401

Closed
iambeingtracked opened this issue Jul 27, 2022 · 9 comments
Closed

Disabling historical rooms #13401

iambeingtracked opened this issue Jul 27, 2022 · 9 comments
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@iambeingtracked
Copy link

Description:
I would like it to be possible to disable historical rooms in synapse. I just want to leave a room and forget about it, not leaving a trail of it in historical rooms.

@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jul 29, 2022
@erikjohnston
Copy link
Member

Doesn't seem unreasonable as a config option, but I don't think we'd implement it ourselves.

@richvdh
Copy link
Member

richvdh commented Aug 1, 2022

I think this is a client-side feature, isn't it? It's the client choosing to present the list of historical rooms, not the server.

(Though #4720 is related)

@iambeingtracked
Copy link
Author

Well, this can be removed on the client side, but I'm not entirely sure whether historical rooms are provided by the client or by the server

@richvdh
Copy link
Member

richvdh commented Aug 1, 2022

I don't think Synapse provides a list of historical rooms. (It used to, but has not done so for a long time.)

@iambeingtracked
Copy link
Author

So in which version was that removed from synapse?

@richvdh
Copy link
Member

richvdh commented Aug 1, 2022

I couldn't say for certain, I'm afraid.

@iambeingtracked
Copy link
Author

@anoadragon453
Copy link
Member

anoadragon453 commented Aug 10, 2022

Synapse does not notify the client that a room has been forgotten, no. It's up to the client to remove it from the room list. See Element Web's code here:

https://github.com/matrix-org/matrix-react-sdk/blob/5fbeb20df864721e2acbb7bff56ff234abf9e3fb/src/components/structures/MatrixChat.tsx#L1178

This also means that if you have 2 Element Web clients, forgetting a room on one will not cause it to disappear from the other.

Additionally, it appears that historical rooms do not come down in an initial sync, so if you log out and log in again all historical rooms will be lost. This makes it difficult to forget them afterwards!

Actually, this last part is apparently Element Web's fault for not setting include_leave to true in the initial sync filter.

@iambeingtracked
Copy link
Author

Okay, I think I should make an issue in https://github.com/vector-im/element-web. Closing the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants