Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Documentation: Clarify contradictory docs about authentication of replication traffic #13302

Closed
haslersn opened this issue Jul 16, 2022 · 3 comments · Fixed by #13656
Closed
Assignees
Labels
A-Docs things relating to the documentation O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@haslersn
Copy link
Contributor

The workers documentation has seemingly contradictory statements about whether replication traffic is authenticated:

Optionally, a shared secret can be used to authenticate HTTP traffic between workers.

Under no circumstances should the replication listener be exposed to the public internet; it has no authentication

@squahtx squahtx added A-Docs things relating to the documentation T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 18, 2022
@richvdh
Copy link
Member

richvdh commented Aug 26, 2022

yeah, the "no authentication" text predates #8853. Mind you, I'm not sure I'd really recommend exposing the HTTP port even if there is a shared secret.

Still, it's definitely incorrect as it stands.

@clokep clokep added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 26, 2022
@haslersn
Copy link
Contributor Author

I'm not sure I'd really recommend exposing the HTTP port

Still, the authentication might influence a decision about whether it's acceptable to have unrelated hosts in the same VLAN or Kubernetes cluster.

@clokep
Copy link
Member

clokep commented Aug 29, 2022

#13656 is a simple clarification of this, not sure there is more to say?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants