This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
annotate tests.server.FakeChannel #13136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2022 00:42
I chose to annotate this as `Dict[str, Any]` (although it could in
principle be any json payload: str, number, list, boolean, null).
Mypy now knows that json_body.get("foo") returns `Optional[Any]` and is
complaining in a few places. I generally replaced these with direct
lookups, since either
- the test would already fail if the key was missing, or
- the test probably ought to fail if the key was missing.
Happy to be persuaded otherwise if you're not convinced.
babolivier
approved these changes
Jul 4, 2022
| @@ -1488,7 +1488,7 @@ def test_create_user_mau_limit_reached_active_admin(self) -> None: | |||
|
|
|||
| if channel.code != HTTPStatus.OK: | |||
| raise HttpResponseException( | |||
| channel.code, channel.result["reason"], channel.json_body | |||
| channel.code, channel.result["reason"], channel.result["body"] | |||
There was a problem hiding this comment.
Why are we changing this?
There was a problem hiding this comment.
Good question. I think I just picked this up during a find-and-replace.
There was a problem hiding this comment.
Ahh, without this change:
tests/rest/admin/test_user.py:1491: error: Argument 3 to "HttpResponseException" has incompatible type "Dict[str, Any]"; expected "bytes" [arg-type]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix up tests that are inspecting json_body.
I chose to annotate this as
Dict[str, Any](although it could inprinciple be any json payload: str, number, list, boolean, null).
Mypy now knows that json_body.get("foo") returns
Optional[Any]and iscomplaining in a few places. I generally replaced these with direct
lookups, since either
Happy to be persuaded otherwise if you're not convinced.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)