Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add thumbnailing support to media repository for SVGs (SYN-344) #1309

Open
matrixbot opened this issue Apr 15, 2015 · 5 comments
Open

Add thumbnailing support to media repository for SVGs (SYN-344) #1309

matrixbot opened this issue Apr 15, 2015 · 5 comments
Labels
A-Media-Repository Uploading, downloading images and video, thumbnailing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@matrixbot
Copy link
Member

Python Image Library can't read SVG so the current PIL based thumbnailing code can't generate a thumbnail for an SVG.

For now we might just want to return the original image since it is already scalable.

(Imported from https://matrix.org/jira/browse/SYN-344)

(Reported by @NegativeMjark)

@matrixbot
Copy link
Member Author

Jira watchers: @NegativeMjark @ara4n

@matrixbot
Copy link
Member Author

this is starting to get annoying given our heavy use of SVGs in vector and similar.

It's bad practice to return the raw SVG (but better than nothing) given if I upload a 2MB SVG it'd suck if everyone ended up downloading a 2MB SVG thumbnail...

-- @ara4n

@matrixbot
Copy link
Member Author

Alternatively we could do something like pyrsvg and http://stackoverflow.com/questions/6589358/convert-svg-to-png-in-python

-- @ara4n

@matrixbot
Copy link
Member Author

Workaround using the original image at 2c838f6. Closing this to hand over to that PR

-- @ara4n

@matrixbot
Copy link
Member Author

had to back this out due to bd77216

-- @ara4n

@matrixbot matrixbot added A-Media-Repository Uploading, downloading images and video, thumbnailing z-p2 (Deprecated Label) z-feature (Deprecated Label) labels Nov 7, 2016
@matrixbot matrixbot changed the title Add thumbnailing support to media repository for SVGs (SYN-344) Add thumbnailing support to media repository for SVGs (https://github.com/matrix-org/synapse/issues/1309) Nov 7, 2016
@matrixbot matrixbot changed the title Add thumbnailing support to media repository for SVGs (https://github.com/matrix-org/synapse/issues/1309) Add thumbnailing support to media repository for SVGs (SYN-344) Nov 7, 2016
@DMRobertson DMRobertson added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. and removed z-p2 (Deprecated Label) z-feature (Deprecated Label) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Media-Repository Uploading, downloading images and video, thumbnailing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants