Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

The all extras package group no longer includes pympler #12648

Closed
anoadragon453 opened this issue May 5, 2022 · 1 comment · Fixed by #12652
Closed

The all extras package group no longer includes pympler #12648

anoadragon453 opened this issue May 5, 2022 · 1 comment · Fixed by #12652
Assignees
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented May 5, 2022

As of #12449, the all extras package group does not automatically install all of the optional dependencies. Specifically, the cache_memory extras group was no longer installed, which meant that without explicitly installing it, it was missing in both the Debian and Docker images we distribute.

The cache_memory extras group installs the pympler package, which is needed to test the caches.track_memory_usage experimental config option. While this is indeed experimental, deployments using the docker images or debian packages can't test it if this dependency is missing.

systemd is another optional dependency which is not installed via all. It enables the systemd.journal.JournalHandler handler as configured in the log config. In the past we have explicitly chosen to exclude this, as it is only needed on systems which use systemd.

However, despite systemd-less versions of Debian in existence, it is needed to configure the above handler on Debian-based Linux distributions with systemd. I'm unsure whether it should be installed on the Docker images (would it be useful to log to systemd on the docker images? I assume they are meant to simply log to stdout?).

(This issue originated from discussion in #12640 (comment)).

@anoadragon453 anoadragon453 added A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers X-Needs-Discussion labels May 5, 2022
@richvdh richvdh changed the title The all extras package group no longer includes all necessary dependencies to run Synapse The all extras package group no longer includes pympler May 5, 2022
@DMRobertson DMRobertson self-assigned this May 5, 2022
@DMRobertson
Copy link
Contributor

Casualty of #12381.

Result of discussion:

  • Let's stick it back in to all, but not worry about releasing a new docker image with pympler present unless someone complains.
  • We still want systemd to not be in all.

We can remove --extras cache_memory from the scripts that export requirements from the debian events, while keeping `--extras systemd.

@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. and removed X-Needs-Discussion labels May 5, 2022
@DMRobertson DMRobertson linked a pull request May 6, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants