Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't use isinstance(..., Sequence) #12123

Closed
squahtx opened this issue Mar 1, 2022 · 0 comments · Fixed by #12128
Closed

Don't use isinstance(..., Sequence) #12123

squahtx opened this issue Mar 1, 2022 · 0 comments · Fixed by #12128
Assignees
@clokep
Labels
good first issue Good for newcomers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@squahtx
Copy link
Contributor

squahtx commented Mar 1, 2022

In a couple of places, we validate incoming lists of strings with isinstance(..., Sequence). Unfortunately this lets plain strings slip through.
We have to make these checks more specific.
@squahtx squahtx added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. good first issue Good for newcomers labels Mar 1, 2022
@clokep clokep self-assigned this Mar 2, 2022
This was referenced Mar 2, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
good first issue Good for newcomers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if instances are lists, not sequences. matrix-org/synapse
2 participants
@clokep @squahtx