This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
User-interactive auth on delete device #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/ui_auth_on_device_delete
branch
from
5a76516 to
fbd3866
Compare
| body = servlet.parse_json_object_from_request(request) | ||
|
|
||
| authed, result, params, _ = yield self.auth_handler.check_auth([ | ||
| [constants.LoginType.PASSWORD], |
There was a problem hiding this comment.
Hmm, this is probably fine for now, but isn't going to work with servers that only allow e.g. LDAP auth.
There was a problem hiding this comment.
or worse, only CAS auth :/
We should probably return a 401 rather than a 400 for existing clients that don't know they have to do the UIA dance to delete a device.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(client-side support is matrix-org/matrix-react-sdk#517)