This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Restructure ldap authentication #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erikjohnston
commented
Sep 29, 2016
erikjohnston
commented
- properly parse return values of ldap bind() calls
- externalize authentication methods
- change control flow to be more error-resilient
- unbind ldap connections in many places
- improve log messages and loglevels
erikjohnston
commented
Sep 29, 2016
| Returns True, LDAP3Connection | ||
| if the bind was successful | ||
| Returns False, None | ||
| if an error occured |
There was a problem hiding this comment.
Any reason not to just return LDAP3Connection or None? Or even throw an exception to make sure the case is handled?
There was a problem hiding this comment.
Actually, i suppose that doesn't fit in with the way the rest of the stuff works.
There was a problem hiding this comment.
Glad to work on this in another iteration.
- properly parse return values of ldap bind() calls - externalize authentication methods - change control flow to be more error-resilient - unbind ldap connections in many places - improve log messages and loglevels
erikjohnston
force-pushed
the
erikj/ldap_restructure
branch
from
ad95843 to
3027ea2
Compare
|
This patch broke my LDAP authentication. Please help me: what's the news in this ldap auth? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.