This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix perf of fetching state in SQLite #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Sep 26, 2016
| # each (type, state_key). However, that was terribly slow | ||
| # without the right indicies (which we can't add until | ||
| # after we finish deduping state, which requires this func) | ||
| if types is not None: |
There was a problem hiding this comment.
can we reorder this to reduce the duplication?
query="SELECT type, state_key, event_id FROM state_groups_state WHERE state_group = ?"
args = [next_group]
if types is not None:
query += where_clause
args += [i for typ in types for i in typ]
txn.exectute(query, args)
# etc
| @@ -389,26 +430,6 @@ def _get_state_groups_from_groups_txn(self, txn, groups, types=None): | |||
| if next_group: | |||
| group_tree.append(next_group) | |||
There was a problem hiding this comment.
what's the point of this? I don't think its used anywhere?
|
(The tests are due to a flakey test, which is being fixed in matrix-org/sytest#315 ) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.