Fix and clean up publicRooms pagination #1129

erikjohnston · 2016-09-17T13:45:55Z

No description provided.

ara4n · 2016-09-17T13:58:33Z

synapse/handlers/room_list.py


-        rooms_to_scan = sorted_rooms
+        # If there's not search filter just limit the range since we'll


ara4n · 2016-09-17T13:59:18Z

it seems plausible to be, and works against my local HS test jig. ship it? :S

erikjohnston assigned ara4n Sep 17, 2016

Fix and clean up publicRooms pagination

71edaae

erikjohnston force-pushed the erikj/fix_pubroom_pag branch from 626e03b to 71edaae Compare September 17, 2016 13:46

ara4n reviewed Sep 17, 2016

View reviewed changes

synapse/handlers/room_list.py

rooms_to_scan = sorted_rooms

# If there's not search filter just limit the range since we'll

Copy link

Member

ara4n Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/not/no/

ara4n assigned erikjohnston Sep 17, 2016

Spelling

a298331

erikjohnston mentioned this pull request Sep 17, 2016

i think this fixes the room pagination limit. #1128

Closed

erikjohnston merged commit eb24aec into develop Sep 17, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and clean up publicRooms pagination #1129

Fix and clean up publicRooms pagination #1129

erikjohnston commented Sep 17, 2016

ara4n Sep 17, 2016

ara4n commented Sep 17, 2016


		rooms_to_scan = sorted_rooms
		# If there's not search filter just limit the range since we'll

Fix and clean up publicRooms pagination #1129

Fix and clean up publicRooms pagination #1129

Conversation

erikjohnston commented Sep 17, 2016

ara4n Sep 17, 2016

Choose a reason for hiding this comment

ara4n commented Sep 17, 2016