From c696a03df8e955b804d5f43cf0ccfeefdec3a00a Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Fri, 11 Feb 2022 11:36:50 +0000 Subject: [PATCH] Fix TODO comment regarding E2E AS reliability (catch-up) --- synapse/storage/databases/main/appservice.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/synapse/storage/databases/main/appservice.py b/synapse/storage/databases/main/appservice.py index a4291bb6514b..06944465582b 100644 --- a/synapse/storage/databases/main/appservice.py +++ b/synapse/storage/databases/main/appservice.py @@ -359,8 +359,9 @@ def _get_oldest_unsent_txn(txn): events = await self.get_events_as_list(event_ids) - # TODO: should we recalculate one-time key counts and unused fallback - # key counts here? + # TODO: to-device messages, one-time key counts and unused fallback keys + # are not yet populated for catch-up transactions. + # We likely want to populate those for reliability. return AppServiceTransaction( service=service, id=entry["txn_id"],