Fix federation inbound age metric. (#10355)

We should be reporting the age rather than absolute timestamp.
matrix-org · Jul 13, 2021 · 879d8c1 · 879d8c1
1 parent c2c364f
commit 879d8c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/10355.bugfix b/changelog.d/10355.bugfix
@@ -0,0 +1 @@
+Fix newly added `synapse_federation_server_oldest_inbound_pdu_in_staging` prometheus metric to measure age rather than timestamp.
diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py
@@ -1230,7 +1230,9 @@ def _get_stats_for_federation_staging_txn(txn):
                 "SELECT coalesce(min(received_ts), 0) FROM federation_inbound_events_staging"
             )
 
-            (age,) = txn.fetchone()
+            (received_ts,) = txn.fetchone()
+
+            age = self._clock.time_msec() - received_ts
 
             return count, age
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix newly added `synapse_federation_server_oldest_inbound_pdu_in_staging` prometheus metric to measure age rather than timestamp.