From 70c88614d178d4a06bf9a4fcdad5f81ebe8c3540 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sat, 1 Apr 2017 04:08:35 +0100 Subject: [PATCH] better commenting. btw, it looks like this never particularly deliberately special-cased non-utf8; when Mjark added utf8 support in https://github.com/matrix-org/synapse/pull/259 he just left the original code path alone, assuming it worked. --- synapse/rest/media/v1/_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/rest/media/v1/_base.py b/synapse/rest/media/v1/_base.py index 21e3d86a228d..54a931fad041 100644 --- a/synapse/rest/media/v1/_base.py +++ b/synapse/rest/media/v1/_base.py @@ -73,7 +73,7 @@ def respond_with_file(request, media_type, file_path, if upload_name: # technically we should only use the crazy *=utf-8'' syntax # if the filename actually contains utf-8. but if we don't, some - # browsers (Chrome at some point before 57, and Firefox 52) get it + # browsers (Firefox 52, Safari 10, Chrome at some point < 57) get it # get it wrong and return %20 verbatim rather than url-decoding it # causing bug https://github.com/vector-im/riot-web/issues/3155 request.setHeader(