From 51d689ae70745d67e288358700cbd3079c5e3073 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Tue, 9 Feb 2021 18:02:14 +0000
Subject: [PATCH] Tiny cleanup to validate_metadata

`validate_jwks_uri` already checks that `jwks_uri` is set.
---
 synapse/handlers/oidc_handler.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/synapse/handlers/oidc_handler.py b/synapse/handlers/oidc_handler.py
index 3adc75fa4ab4..d3cfa27d06bb 100644
--- a/synapse/handlers/oidc_handler.py
+++ b/synapse/handlers/oidc_handler.py
@@ -341,10 +341,7 @@ def _validate_metadata(self):
         else:
             # If we're not using userinfo, we need a valid jwks to validate the ID token
             if m.get("jwks") is None:
-                if m.get("jwks_uri") is not None:
-                    m.validate_jwks_uri()
-                else:
-                    raise ValueError('"jwks_uri" must be set')
+                m.validate_jwks_uri()
 
     @property
     def _uses_userinfo(self) -> bool: