Faster joins: use initial list of servers if we don't have the full s…

…tate yet (#14408) Signed-off-by: Mathieu Velten <[email protected]> Co-authored-by: Sean Quah <[email protected]>
matrix-org · Nov 24, 2022 · 39cde58 · 39cde58
1 parent c2e06c3
commit 39cde58
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/changelog.d/14408.misc b/changelog.d/14408.misc
@@ -0,0 +1 @@
+Faster joins: send events to initial list of servers if we don't have the full state yet.
diff --git a/synapse/federation/sender/__init__.py b/synapse/federation/sender/__init__.py
@@ -434,7 +434,23 @@ async def handle_event(event: EventBase) -> None:
                         # If there are no prev event IDs then the state is empty
                         # and so no remote servers in the room
                         destinations = set()
-                    else:
+
+                    if destinations is None:
+                        # During partial join we use the set of servers that we got
+                        # when beginning the join. It's still possible that we send
+                        # events to servers that left the room in the meantime, but
+                        # we consider that an acceptable risk since it is only our own
+                        # events that we leak and not other server's ones.
+                        partial_state_destinations = (
+                            await self.store.get_partial_state_servers_at_join(
+                                event.room_id
+                            )
+                        )
+
+                        if len(partial_state_destinations) > 0:
+                            destinations = partial_state_destinations
+
+                    if destinations is None:
                         # We check the external cache for the destinations, which is
                         # stored per state group.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Faster joins: send events to initial list of servers if we don't have the full state yet.