Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for unbinding addresses #399

Open
anoadragon453 opened this issue Sep 13, 2021 · 2 comments
Open

Add tests for unbinding addresses #399

anoadragon453 opened this issue Sep 13, 2021 · 2 comments
Labels
help wanted

Comments

@anoadragon453
Copy link
Member

#398 seem to indicate that neither Sydent itself nor matrix-is-tester seem to have tests for POST /_matrix/identity/v2/3pid/unbind.

It would be good to get some so that similar issues can be caught in CI in the future.
@clokep clokep mentioned this issue Sep 14, 2021
Open
@anoadragon453
Copy link
Member Author

Extra testing likely could have also helped with #400

Curiously we should have replication unit tests already though, so I'm not sure why this wasn't caught...

@DMRobertson
Copy link
Contributor

I added one test case here: #466

But that's not the comprehensive coverage that this issue is looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoadragon453 @DMRobertson