Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSC3946: Dynamic room predecessor #38

Open
andybalaam opened this issue Mar 22, 2023 · 1 comment
Open

Add support for MSC3946: Dynamic room predecessor #38

andybalaam opened this issue Mar 22, 2023 · 1 comment
Labels
api enhancement New feature or request
Milestone

Comments

@andybalaam
Copy link
Member

MSC3946 enables us to specify the predecessor room using a new state event instead of the create event.

This doesn't have much effect on the sliding sync proxy, but it does affect the list of rooms that are returned under certain circumstances.

As I understand it, predecessor rooms should normally be excluded from the list of returned rooms, so the proxy will need to determine the predecessor using the new state event if present. I believe this will be needed if the include_old_rooms filter is active.

I implemented this stuff in matrix-js-sdk - happy to help if you have any questions. The most relevant code is probably in findPredecessor in room-state.ts.

@DMRobertson DMRobertson added the enhancement New feature or request label Mar 23, 2023
@kegsay kegsay added this to the v1 milestone Mar 27, 2023
@DMRobertson
Copy link
Contributor

We do similar things for m.room.create as part of supporting the include_old_rooms flag. It should be easy to replicate the lookup.

The problem is that we had assumed that predecessors never change. But now it can. Will have to update some SQL and also the caches.

Relevant source:
https://github.com/matrix-org/sliding-sync/blob/main/state/rooms_table.go#L15
https://github.com/matrix-org/sliding-sync/blob/main/state/rooms_table.go#L49 need to be more selective about what "latches on"

@DMRobertson DMRobertson modified the milestones: v1, v1.1 Apr 25, 2023
@kegsay kegsay added the api label Jul 20, 2023
@kegsay kegsay removed the roadmap label Aug 1, 2023
@DMRobertson DMRobertson removed their assignment Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants